Skip to content

Conversation

ban-abhijit
Copy link

Fixes #7917
Also checks for some other image like things, e.g. p5.Graphics or p5.MediaElement (for a webcam capture) or p5.Texture or p5.Framebuffer
I'm a first timer and happy to hear feedbacks

Copy link
Collaborator

@perminder-17 perminder-17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ban-abhijit, thanks a lot for working on this. I noticed there are quite a few formatting changes that aren’t really needed for this PR. For next time, it would be great if you could double-check your changes and remove anything unnecessary before submitting.

Also, since this issue was already assigned to someone else and you’ve opened a PR, I’ll need to close this one as a duplicate of #7963. Thanks for your effort and understanding!

@ban-abhijit
Copy link
Author

Hi @perminder-17 thanks for making me realize my rookie mistakes. I just wanted to know I made a change in a function of single file, ran the lint fix command and then had submitted the pr. How did the formatting of the whole file got messed up? and how can I check and fix it from the next time? Also, sorry for the inconvenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WEBGL background image bug
2 participants