Skip to content

Conversation

perminder-17
Copy link
Collaborator

Changes:

  • Add some more spline() example that uses ends: INCLUDE.
  • Open a PR in p5.js-website to fix asset handling where images were being uploaded directly.
  • Add this example demonstrating ends: EXCLUDE to both splineVertex() and splineProperty() pages.
  • Add additional examples to splinePoint().

Screenshots of the change:

PR Checklist

Copy link
Member

@ksen0 ksen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @perminder-17 !

@perminder-17 perminder-17 merged commit a4fbdaa into processing:dev-2.0 Sep 10, 2025
2 checks passed
@perminder-17
Copy link
Collaborator Author

Looks like the tests are failing after merging, looking into the issue!

@perminder-17
Copy link
Collaborator Author

The failing test was actually unrelated to this PR, It passed on re-run because the failure was a flaky visual screenshot test. The mismatch likely came from font rendering in typography.

If this is unexpected, paste these URLs into your browser to inspect them. If this change is expected, please delete the screenshots/Typography/textWeight/can 
control non-variable fonts folder and run tests again to generate a new screenshot. ❯ test/unit/visual/visualTest.js:469:19 467| const result = await checkMatch(actual[i], expected[i], myp5… 468| if (!result.ok) { 469| throw new Error( | ^ 470| Screenshots do not match! Expected:\n${toBase64(expecte… 471| 'If this is unexpected, paste these URLs into your brows… ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯
[1/1]⎯ Test Files 1 failed | 64 passed | 4 skipped (69) Tests 1 failed | 1694 passed | 12 skipped | 50 todo (1934) Start at 15:45:30 Duration 141.39s (transform 0ms, setup 0ms, collect 23.45s, tests 91.84s, environment 0ms, prepare 9.74s) Error: Error: Screenshots do not match! Expected: data:image/
png;base64,iVBORw0KGgoAAAANSUhEUgAAADIAAAAyCAYAAAAeP4ixAAAFeUlEQVR4AexWZ0iWXxT/PU9FmwpaVB+sD30ookFRX+pDURFENIgGDRpUEC2KgooGTXLgFvcAcYB74sQBioKKihsEcaE4cOD2/+935BE1yvd5fZ8IeV8497733HPPfc76nav+N09+KubJz2rIvxZIQyMyPj6OlpaWv2KzoYa4ublh06ZNqKqqmmbM6Ogouru7p/HmutBtiLu7Ow4ePIgNGzZgzZo1WLt2LXbu3IkPHz7It3R0dODKlSvw9fVFSUmJ8Hp7e2XWhuPHj8u5oqIijTXnWZchGRkZePjwIQoKCtDW1iZe5YdXVFSAe/wafnRsbCzu3r0LPz8/
svDt2zesW7cOX758kfXChQtBGhsbk7UlBt2G8NK3b9+iq6sLw8PDYB38bEXIzs7mFmxsbFBWVoYdO3bImkNUVBQWLFiAjRs3comkpCRxxIEDB2RtiWHSEOZteHg4Xr58iWvXruHVq1fIzc2ddge9T8auXbuwevVqLFq0CIqikDWNcnJywChpzLNnz0rR37lzR1hxcXGws7MD7yRjZGQETNnTp09j3759OHHiBD5+/Ag9dSSG0LM8fOnSJdja2iI4OBg/fvzA4cOH8eTJE94ltHTpUpnJO3LkCC5fvgwXFxc0NzcLXxtYHytWrEBaWppEITo6Go2Njdo2vLy88OnTJ9TV1Qnv/v37krIJCQkoLi5Gamqq1NyzZ89k35RBDPHx8UFmZqaE/82bN2BkmONU4OzsDOY8/7NIt2/fDlVVkZ+fj7CwMDx+/Bjbtm1DTEwMRYR4vrq6GseOHYO9vT327t2LxYsXyx4HLRKsEXrd399fwCMvLw/t7e0oLCyUiBE0KG8KiSGhoaEi+/79e3z+/BkXL16Et7c3rl+/Lnxt/9SpU+AHNjU1YXBwEOXl5bhx4waGhoZw4cIFNDQ0iDxrgbDLxdWrV0F0Wr9+PZe/kGZUT08PampqsGTJEuzfvx/Pnz+XFPvlwG8YKouVKMT9kydPcpqk8+fPy//
KykqZpw6MCmE3MDAQhw4dAr2rFfxUuT/9VxRFYPjWrVsYGBjAzZs3pfYYSUb1T2dn7qkMJT3KDRrFWSNFmSjk/v5+YRGtXrx4If+nDvQg1319fZx0E2sqMTFRMmDVqlUC5axXV1dXk3Wp2kfyRHx8PKdJYpFysWfPHk5wcnKSnO/s7JS1Nmide/PmzRrLpFlRJhylKAqYtkFBQWhtbcXXr1/lfEhIiMymDCoRSxNkw3r69ClYfMztgIAA2dJgc/
fu3bJmyqWkpEhjJDgQndjwiGQioGPIysoCUau0tFR6Eo9qwLBs2TIuTSKVvUCTpAJ6/
fbt26A3CLdca7XDTm3zs+HxcvL4VKH3KOfp6QmmhabLlFlRFNTX1wsc00ks9OXLl0uh8/yjR484mUQqD1OSRvBt9P37dxC/PTw8BEUIr9wnEXrZ6CIiIvD69WuwXtjYamtrce7cOYroJiIja4Q1QdA4evQo7t27JxB85swZk/Wp9CalWfBbt26Vju7g4IAHDx5gy5Yt3JpGlGdqMQ3ZPAmTemuDnZxK+WwhMQMI8US95ORkMLoagFDOFFIZSk1war1oPB2zSaK8g32Fwuw3nC1BKlOKRGWKMoEi/G9pYuPjy5npwxcyn0QrV6602DXS2d+9eydvKr6PLKZ5hiIaEhkZKa8B1gGBY4bInJZiCAvX0dFxTopmO0xQ4dOGfSs9PR1662o2/WLIbEKW2uezZircW0ov9fxVQ3ihUWQ1xCjPmqvXGhFzPWfUOWtEjPKsuXqtETHXc0ads0bEKM+aq9caEXM9Z9Q5a0SM8qy5ev/ViOi2x2qIbpcZfMAaEYMdrFu9NSK6XWbwAWtEDHawbvXzJiL/AwAA///s0zMeAAAABklEQVQDAJ1D0btPBP/UAAAAAElFTkSuQmCC Received: data:image/
png;base64,iVBORw0KGgoAAAANSUhEUgAAADIAAAAyCAYAAAAeP4ixAAAFt0lEQVR4AexXV2hUSxj+9ti7YgEL9i723okIihURNYgPCoqiiIKICjYUFUURxYYllRBSnlJJSH3JSyrpIT0hjSSE9J579xvvGTZn9yRuSO5KOGFn5m8zc/4+Uf4ZJn8Khsmfocjf5kjDI01NTQgPD8eXL1/w+vVreHt7o6qqStdR5poCX19f/Pz5E9yrFSTtzJkzmDJlChYvXozY2FitSJ/4gDySm5uLlStX4tChQ7hx4wb

On re-running the tests, it started to pass.

Maybe we need to look at this again : #7823.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants