-
Notifications
You must be signed in to change notification settings - Fork 413
fix -hi
response
#1142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
fix -hi
response
#1142
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change breaks -http-directory
and -dynamic-resp
option, we need to ensure both options works as expected along with this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation breaks the existing reflection functionality, ex:
$ curl "http://localhost/aaa" -H "Host: a.d30rdlnirrqmn1ona83gius5yy3yfsjkd.127.0.0.1"
<html><head></head><body>dkjsfy3yy5suig38ano1nmqrrinldr03d</body></html>%
Maybe we should introduce another flag that takes priority over other flags (something like -default-file
)? What do you think?
No description provided.