Skip to content

fix: parse.js "parent.add(oneof)“ error (#1602) #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: parse.js "parent.add(oneof)“ error (#1602) #1604

wants to merge 1 commit into from

Conversation

alexander-fenster
Copy link
Contributor

Cc: @leon776

Cherry-picking your commit from #1602 to master.

leon776
leon776 reviewed Jun 2, 2021
View reviewed changes
Copy link
Contributor

@leon776 leon776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

leon776
leon776 suggested changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@leon776 leon776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@leon776 leon776 leon776 requested changes

@galaxycores galaxycores galaxycores approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-fenster @leon776 @galaxycores