litmus:install_agent does not work on EL since PR #754

[Henrik-Hansson]

Describe the Bug

litmus:install_agent does not work on EL systems since #754 was merged.
Without access to https://artifactory.delivery.puppetlabs.net:443/artifactory/internal_nightly__local/yum, litmus can't install the Puppet agent.

Expected Behavior

Expected behavior is that litmus:install_agent should be able to download the agent.

Steps to Reproduce

Steps to reproduce the behavior:

1. Run litmus:install_agent on any EL system

Environment

• main branch
• All YUM/DNF based OS
• puppet-7-nightly, puppet-8-nightly'

Additional Context

I have seen the same issue for puppetlabs-stdlib PR#391:
https://github.com/puppetlabs/puppetlabs-stdlib/actions/runs/13273038130/job/37056797419?pr=1448

The error message from puppetlabs-stdlib:
Installation of agent failed.
Results:
8b851ca1970b: {"_output"=>"21:42:30 +0000 INFO: Version parameter not defined and no agent detected. Assuming latest.\n21:42:30 +0000 INFO: Downloading Puppet latest for el...\n21:42:30 +0000 INFO: Red hat like platform! Lets get you an RPM...\n21:42:30 +0000 INFO: Downloading https://artifactory.delivery.puppetlabs.net:443/artifactory/internal_nightly__local/yum/puppet7-nightly-release-el-8.noarch.rpm\n21:42:30 +0000 INFO: to file /tmp/install.sh.231.42299/puppet7-nightly-release-el-8.noarch.rpm\n21:42:30 +0000 INFO: Trying curl...\n21:42:30 +0000 INFO: Retrying... [1/5]\n21:42:30 +0000 INFO: Return code: 6\n21:42:31 +0000 INFO: Retrying... [2/5]\n21:42:31 +0000 INFO: Return code: 6\n21:42:32 +0000 INFO: Retrying... [3/5]\n21:42:32 +0000 INFO: Return code: 6\n21:42:33 +0000 INFO: Retrying... [4/5]\n21:42:33 +0000 INFO: Return code: 6\n21:42:34 +0000 INFO: Retrying... [5/5]\n21:42:34 +0000 INFO: Return code: 6\n21:42:35 +0000 CRIT: Cannot download package as none of wget/curl/fetch/perl-LWP-Simple/perl-File-Fetch/python3/apt-helper is found\n21:42:35 +0000 CRIT: Unable to retrieve a valid package!\n", "_error"=>{"kind"=>"puppetlabs.tasks/task-error", "issue_code"=>"TASK_ERROR", "msg"=>"The task failed with exit code 1", "details"=>{"exit_code"=>1}}}}

[joshcooper]

We introduced a breaking change to the puppet_agent module in PR 754 and there will be more breaking changes landing, such as dropping puppet 6 support, see #757

You should pin to a version of the puppet_agent module in your .fixtures.yaml for example https://github.com/puppetlabs/puppetlabs-concat/blob/1a09419642af19ddce60e379caad0143faf0a950/.fixtures.yml#L5-L7 The last tag before the breaking changes was v4.22.0 so you'll probably want to use that.

[bastelfreak]

Did you communicate this to the modules team? The module is used a lot in combination with litmus, so their tests break now. And now nobody can run the module tests locally anymore, and this isn't documented anywhere.

[joshcooper]

Yeah this is my bad. I didn't realize that litmus recommends running from the HEAD of puppet_agent https://github.com/puppetlabs/litmus/blob/d061899e4bf46f2bad5395a09b4da197592b3e28/Converting-modules-to-use-Litmus.md?plain=1#L34

We probably should revert the change in 754, send out communication about breaking changes that we intend to make in the module along with a date of when that will happen.

[bastelfreak]

Yes I think that would be good.