Skip to content

Conversation

oiao
Copy link
Contributor

@oiao oiao commented Jul 3, 2025

nn.Sequential is used in multiple graph convolutional layers throughout the code. However, the current implementation of the swish activation is incompatible with this pattern:

from torch import nn
from torch_geometric.nn.resolver import activation_resolver
nn.Sequential(activation_resolver('swish'))
TypeError: torch_geometric.nn.resolver.swish is not a Module subclass

This PR replaces swish with class Swish(nn.Module).

@oiao oiao requested a review from EdisonLeeeee as a code owner July 3, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant