Densityplot: add support for discrete variables #2878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you post a screen shot/example of what this looks like? Maybe also a test (our plotting "tests" are just making sure you can call the functions)? |
|
In this example sigma is continuous and gamma discrete
Densityplot is already included in our tests (see #2741) |
|
ups! I just notice a problem (with the xticks) |
junpenglao
reviewed
Mar 1, 2018
| bins = range(xmin, xmax+1) | ||
| if outline: | ||
| ax.hist(vec, bins=bins, color=c, histtype='step') | ||
| ax.hist(vec, bins=bins, color=c, alpha=shade) |
There was a problem hiding this comment.
Better to set density=None to True.
There was a problem hiding this comment.
That will only change the scale of y. But that scale is not plotted, the yticks are set to an empty list.
|
This is how it looks like with the fix
|
twiecki
reviewed
Mar 2, 2018
pymc3/plots/densityplot.py
Outdated
| """ | ||
| if point_estimate not in ('mean', 'median', None): | ||
| raise ValueError("Point estimate should be 'mean' or 'median'") | ||
| raise ValueError("Point Estimate should be 'mean', 'median' or None") |
|
This looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.