Skip to content

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Jan 11, 2024

Description

Extend dataset_to_point_list to accept both dataset (current behaviour) or a dictionary
of dataarrays. This will help with getting values from InferenceData into pymc functions
with even less overhead and conversions.

Related Issue

  • Closes #
  • Related to #

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7097.org.readthedocs.build/en/7097/

@OriolAbril OriolAbril requested a review from ricardoV94 January 11, 2024 14:02
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bb2ccd) 92.21% compared to head (bedded8) 92.23%.
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7097      +/-   ##
==========================================
+ Coverage   92.21%   92.23%   +0.02%     
==========================================
  Files         101      101              
  Lines       16912    16883      -29     
==========================================
- Hits        15595    15572      -23     
+ Misses       1317     1311       -6     
Files Coverage Δ
pymc/util.py 80.76% <100.00%> (+0.26%) ⬆️

... and 52 files with indirect coverage changes

@ricardoV94 ricardoV94 added the trace-backend Traces and ArviZ stuff label Jan 11, 2024
@ricardoV94 ricardoV94 changed the title extend dataset_to_point_dict to accept both dataset and dict of dataarray Extend dataset_to_point_dict to accept both dataset and dict of dataarray Jan 11, 2024
@ricardoV94
Copy link
Member

mypy is unhappy

@ricardoV94 ricardoV94 merged commit 6f8f9ee into pymc-devs:main Jan 12, 2024
@ricardoV94
Copy link
Member

Thanks @OriolAbril !

@OriolAbril OriolAbril deleted the ds_dict branch January 12, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance trace-backend Traces and ArviZ stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants