Add compute_deterministics
helper
#7238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #7206 this utility becomes more relevant.
Also refactored the base logic to apply a Dataset to a PointFunc which was needed in a couple of places (here and in pymc-experimental).
This function could plausible be used by
sample_prior_predictive
andsample_posterior_predictive
, but it seems that for backward compatibility these return and accept more diverse kinds of inputs. Let me know if I am wrong.I am not so sure where to place the
compute_deterministics
. I put it in thesampling
module which is a bit odd perhaps.Related Issue
pm.compute_deterministics
to compute any deterministics on demand #7221Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7238.org.readthedocs.build/en/7238/