Skip to content

Fix draws of Weibull when alpha and beta implicitly define size #7288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2024
Merged

Fix draws of Weibull when alpha and beta implicitly define size #7288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e6a63d
Broadcast shapes of alpha and beta in Weibull rng
tomicapretto Apr 28, 2024
82937ed
Update test according to suggestions
tomicapretto Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pymc/distributions/continuous.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2499,6 +2499,8 @@ def __call__(self, alpha, beta, size=None, **kwargs):

@classmethod
def rng_fn(cls, rng, alpha, beta, size) -> np.ndarray:
if size is None:
size = np.broadcast_shapes(alpha.shape, beta.shape)
return np.asarray(beta * rng.weibull(alpha, size=size))


Expand Down
8 changes: 8 additions & 0 deletions tests/distributions/test_continuous.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2369,6 +2369,14 @@ def seeded_weibul_rng_fn(self):
"check_rv_size",
]

def test_rng_different_shapes(self):
# See issue #7220
rng = np.random.default_rng(123)
alpha = np.abs(rng.normal(size=5))
beta = np.abs(rng.normal(size=(3, 1)))
draws = pm.draw(pm.Weibull.dist(alpha, beta), random_seed=rng)
assert len(np.unique(draws)) == draws.size


@pytest.mark.skipif(
condition=_polyagamma_not_installed,
Expand Down