Use more numerically stable function in TruncatedNormal area computation #7305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you add a test that checks the improved stability (and would fail before the changes)? |
|
I tried. Turns out to not be easy to condense down to a simple example. |
ricardoV94
changed the title
ricardoV94
approved these changes
May 21, 2024
|
Thanks @velochy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the complex logic for area computation in TruncateNormal with a single, more numerically stable function meant for exactly that computation.
Related Issue
This is mainly code cleanup, although I did run into a few cases where it actually improves convergence.
Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7305.org.readthedocs.build/en/7305/