Skip to content

Allow customizing truncation max_n_steps in Hurdle Mixtures #7339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 31, 2024
Merged

Allow customizing truncation max_n_steps in Hurdle Mixtures #7339

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
50b2579
Redirect kwargs to appropriate distribution
tjburch May 30, 2024
712851b
Consistent key/value names in back to back dict comprehensions
tjburch May 30, 2024
931eda7
Remove upper. Pass max_n_steps to signature.
tjburch May 30, 2024
e63fdec
Pass max_n_steps only if defined so truncated will use default
tjburch May 30, 2024
48dd04a
Reuse default value
tjburch May 30, 2024
1087728
mypy complaining? Maybe the type hint
tjburch May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pymc/distributions/mixture.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,7 @@ def dist(cls, psi, mu=None, alpha=None, p=None, n=None, **kwargs):
)


def _hurdle_mixture(*, name, nonzero_p, nonzero_dist, dtype, **kwargs):
def _hurdle_mixture(*, name, nonzero_p, nonzero_dist, dtype, max_n_steps=10_000, **kwargs):
"""Helper function to create a hurdle mixtures

If name is `None`, this function returns an unregistered variable
Expand All @@ -819,7 +819,7 @@ def _hurdle_mixture(*, name, nonzero_p, nonzero_dist, dtype, **kwargs):
weights = pt.stack([1 - nonzero_p, nonzero_p], axis=-1)
comp_dists = [
DiracDelta.dist(zero),
Truncated.dist(nonzero_dist, lower=lower),
Truncated.dist(nonzero_dist, lower=lower, max_n_steps=max_n_steps),
]

if name is not None:
Expand Down