Pydantic MuEffect
#1922
Pydantic MuEffect
#1922
Conversation
…alization when saving and loading models
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1922 +/- ##
===========================================
- Coverage 92.00% 71.04% -20.97%
===========================================
Files 66 66
Lines 7853 7856 +3
===========================================
- Hits 7225 5581 -1644
- Misses 628 2275 +1647 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| self.fourier = fourier | ||
| self.date_dim_name: str = date_dim_name | ||
| fourier: InstanceOf[FourierBase] | ||
| date_dim_name: str = Field("date") |
There was a problem hiding this comment.
Do we need to supply the date_dim_name here, as the mutltidimensional MMM has the date_column attribute?
There was a problem hiding this comment.
yes, because MuEffect is just an interface that has nothing to do with an MMM class.
So either we have this explicit date_dim_name or we need to introduce coupling with the MMM class.
| @@ -259,6 +263,8 @@ class LinearTrendEffect: | |||
| The LinearTrend instance to wrap. | |||
| prefix : str | |||
| The prefix to use for variables in the model. | |||
| date_dim_name : str | |||
There was a problem hiding this comment.
Same date_dim_name question as with FourierEffect.
Description
Provides serialization/deserialization of MuEffect using Pydantic BaseModel
Related Issue
Checklist
pre-commit.ci autofixto auto-fix.📚 Documentation preview 📚: https://pymc-marketing--1922.org.readthedocs.build/en/1922/