socket fixes #1093
Merged
socket fixes #1093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undingen
force-pushed
the
socket_fixes
branch
3 times, most recently
from
380d7e7 to
c693abf
Compare
undingen
force-pushed
the
socket_fixes
branch
from
c693abf to
bccdc51
Compare
The socket implementation used to only call close on a socket when all references where gone. This works fine for cpython which uses reference counting but for pyston (and pypy) this is a problem. This works around the problem in a similar way as pypy does. It also uses the same method names so that 3th party libs which already support pypy will automatically work with pyston too. (e.g. urllib3)
undingen
force-pushed
the
socket_fixes
branch
from
bccdc51 to
e46c059
Compare
|
Awesome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket implementation used to only call close on a socket when all references where gone.
This works fine for cpython which uses reference counting but for pyston (and pypy) this is a problem.
This works around the problem in a similar way as pypy does.
It also uses the same method names so that 3th party libs which already support pypy will automatically work with pyston too.
(e.g. urllib3)
I would prefer if we get ref counting but meanwhile this improves the situation a lot. (While I'm not sure if this does not break other stuff but I would prefer to not spend to much time on this now if it may get replaced soon)