add the _locale and cPickle modules #1098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The static variables should be fine because this is compiled as shared object which we the GC will automatically scan.
undingen
force-pushed
the
locale
branch
3 times, most recently
from
148c0b4 to
be09856
Compare
the module is much faster than the python implementation But I had to change the code a little bit because of our GC and more importantly because some of our types have different names etc... I also noticed that we failed to to set capifunc.__module__ in a lot of cases which made pickle error
undingen
changed the title
kmod
added a commit
that referenced
this pull request
Feb 13, 2016
add the _locale and cPickle modules
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_localemodulecPicklemodulethe module is much faster than the python implementation (in a small benchmark by about 4x)
But I had to change the code a little bit because of our GC and more importantly because some of our types have different names etc...
I also noticed that we failed to to set
capifunc.__module__in a lot of cases which made pickle error