Threading and multiprocessing related fixes #1120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undingen
force-pushed
the
threading_fixes
branch
3 times, most recently
from
39b2996 to
3c340a7
Compare
this caused problems inside the multiprocessing module
…n str types if we get the attrwrapper of an object, then change it to be dict-backed, the original attrwrapper should remain valid but no longer connected to that object.
undingen
force-pushed
the
threading_fixes
branch
from
3c340a7 to
ca7c5b8
Compare
undingen
changed the title
|
should be ready for review |
kmod
added a commit
that referenced
this pull request
Mar 10, 2016
Threading and multiprocessing related fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to merge the attrwrapper code with our dict code. But sadly this introduced quite some slowdown which make me switch back to this minimal fix.