Add README for building using Vagrant and Ansible #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, but do we have a vagrant file? |
|
Yes, we do have a vagrant file |
|
Oh, ok didn't realize that this was on top of the other PR. It might be nice to rebase your commit on top of that other PR and then submit them together as the PR, since we would want to merge them at the same time (not one without the other). Your doc mentions the |
|
Yes, that makes sense. :) Yea, the directory gets created automatically that way. |
|
Hi @KrishMunot , I saw your PR is using vagrant and ansible, but #1104 dosen't using ansible, and the |
Closed
kmod
force-pushed
the
master
branch
2 times, most recently
from
352fd89 to
6488a3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.