Replace None with Py_None and some other fixing. #1303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| FunctionMetadata::create((void*)getIdent, BOXED_INT, 0), "get_ident")); | ||
| thread_module->giveAttr("stack_size", new BoxedBuiltinFunctionOrMethod( | ||
| FunctionMetadata::create((void*)stackSize, BOXED_INT, 0), "stack_size")); | ||
| thread_module->giveAttr( |
added 3 commits
July 21, 2016 01:19
When try to support tk. The Py_None is a wrapper of pyston `None`. It will conflict with other library's None. So rename the pure pyston `None` to pyston_None. And use Py_None instead pyston_None when possible. Just like dropbox#1231 for Py_True and Py_False
Pyston already has Py_IgnoreEnvironmentFlag, just add it to sys.flags.
|
Working on scikit-learn support. So move the |
|
thanks for the change! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spit it from tk_support PR. I will improve that PR on weekend.