add -a flag which outputs assembly of ICs

[tjhance]

In an effort to better understand the performance of our ICs

Add -a flag, which will dump a disassembly of all the ICs to stderr. Next it would be nice to construct a good test program that exercises a representative sample of ICs.

Here's an example output:

    nop   
; _getAttr
    movq    (%rdi), %rax
; _addAttrGuard
    movabsq $79188951816, %r8
    cmpq    336(%rax), %r8
    jne 613
; _addAttrGuard
    movabsq $79188493320, %r8
    cmpq    (%rax), %r8
    jne 594
; _addAttrGuard
    movabsq $79188828936, %r8
    cmpq    384(%rax), %r8
    jne 571
; _getAttr
    movq    392(%rax), %rax
; _getAttr
    movq    32(%rax), %rax
; _addAttrGuard
    movabsq $79188558856, %r8
    cmpq    (%rax), %r8
    jne 541
; _getAttr
    movq    (%rdi), %r8
; _addGuard
    movabsq $79188940584, %r8
    cmpq    %rax, %r8
    jne 519
; _call 
    movabsq $1311768467294899695, %rax
    incl    (%rax)
    movabsq $10410624, %r11
    callq   *%r11 
; commitReturning
; mark inside ic
    movabsq $1311768467294899695, %rcx
    decl    (%rcx)
; live outs

[undingen]

nice, this will help debugging the new jit tier

[tjhance]

One of the llvm headers I had to include required me to add -Wno-non-virtual-dtor to our build. That kinda sucks... If this is a big deal, maybe I can figure out how to add it to just the one file disassemble.cpp?

[toshok]

oh that output is awesome

On Thu, Jun 25, 2015 at 12:51 AM, Travis Hance [email protected]
wrote:

One of the llvm headers I had to include required me to add
-Wno-non-virtual-dtor to our build. That kinda sucks...

—
Reply to this email directly or view it on GitHub
#643 (comment).

[tjhance]

I added a script that runs all the *_ics.py tests and outputs some stats

[kmod]

It'd be nice to not turn this off -- maybe we could do a #pragma clang diagnostic ignored "-Wnon-virtual-dtor" + push+pop around the offending include? Here's an example of another place we did that. Not sure if we'd need another pragma for gcc.

[tjhance]

addressed your comment, kmod

[tjhance]

ping

is this okay to be merged in?

[kmod]

Ah whoops. I think it has the issue that it shows the assembly pre-relocation, but I think your next PR addresses that.