Improve dictionary performance #822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backstory is that while we do a pretty decent job of avoiding using dictionaries where CPython does, I was running into some cases where we use them as well, and we're slower since our dictionaries are slower. This particular example was instantiating namedtuples, since the namedtuple class is created in an exec, and so when we get inside its
__init__
, we have to do slow lookups to access any of the builtins. We could also try to optimize those cases specifically, or we could make our hidden class logic a "dict storage strategy" or some such.But anyway, this pr just does some quick&easy things: