Optionally move objects around in memory to prepare Pyston for a moving collector. #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Ok I think I addressed everything except making ChunkedStack global. |
|
(Those new commits will be squashed with the other ones by the way). I was afraid using templates for |
|
If the callers can see the casting-template, I think they'll end up inlining it and we'll generate the exact same code. |
rudi-c
force-pushed
the
movingmerge
branch
4 times, most recently
from
925e2bf to
2d1c177
Compare
They tends to time out or just make the test suite run for longer. They definitely times out when running a prototype moving gc.
It's easier to tell the two constants apart if they are different.
Moving gcs will need this to update pointers. There should not be any extra dereference, it will just happen on the other side of the function. Use templates to avoid direct (void**) casts -- make sure we're always passing an pointer of the form T**.
- Refactor the stack logic into a separate data structure ChunkedStack, keep the push function that deals with marking as functionality specific to a subclass of ChunkedStack (no virtual, just reuse code). - Add an additional (disabled) phase that maps out the reference graph reachable objects after the sweep phase. Prepare moving all objects in the small heap. Also, rename TraceStack to TraversalWorklist because the fact that we're using a stack is an implementation detail.
This will reallocate all objects in the small heap and update all references that were pointing to this object. This is not functional yet, there are still references that we are not tracking at other points in the program, so it's still gated behind the MOVING_GC flag.
kmod
added a commit
that referenced
this pull request
Sep 4, 2015
Optionally move objects around in memory to prepare Pyston for a moving collector.
|
Just under the wire :) Thanks for all your work this summer rudi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the code that does the moving by changing
MOVING_GCingc.h