rewrite oldstyle class getattro #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undingen
force-pushed
the
perf_oldstyle2
branch
from
93ff01a to
4975866
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just rewrites attribute reads, this helps a small microbenchmark I created but doesn't show up on our benchmarks.
I tried to also rewrite some attribute calls but it didn't work because I had to add guards after call instructions, so I removed it again.
At some point we should change the instance_* funcs to integrate the getattr+runtimeCall like we do for callattr to really fix the perf issue. But it looks like oldstyle classes aren't used often enough currently to make this a priority.