Improve comments, rename CLFunction #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and a couple of the other related functions: - addRTFunction is now an overload of FunctionMetadata::addVersion - boxFunctionMetadata is now createFunctionFromMetadata (it doesn't return a box) - createRTFunction was just a wrapper around new FunctionMetadata(), so get rid of it - boxRTFunction is now FunctionMetadata::create "CLFunction" never really made sense as a name, and some of the other related functions didn't make sense either (especially after a couple refactorings happened). Hopefully this makes it less confusing.
kmod
added a commit
that referenced
this pull request
Nov 3, 2015
Improve comments, rename CLFunction
|
Love the reduced amount of test flakes :) This test did timeout though, will try to address that in an upcoming PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of changes due to the rename, but it's just renaming things and then formatting.