Limit length of read operation in ImageFont._load_pilfont_data() #9181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

radarhere wants to merge 3 commits into python-pillow:main from radarhere:pilfont

Member

radarhere commented Sep 2, 2025

A few ImageFont._load_pilfont_data() suggestions.

Remove an unnecessary split()

Pillow/src/PIL/ImageFont.py

Line 132 in 31eee6e

file.readline().split(b";")
Check image mode before reading from file, to return the error faster.
Rather than potentially reading an entire line,

Pillow/src/PIL/ImageFont.py

Line 129 in 31eee6e

if file.readline() != b"PILfont\n":

we can limit the length of the read operation by just using read(8).

radarhere added 3 commits

September 2, 2025 21:09


          Removed unused split

57a5f76


          Limit length of read operation

485d988


          Raise mode error before reading

caacd38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet