Do not unnecessarily update FLI __offset #9184
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FliImagePlugin,
self.__offset
is initially set to 128, and may then be updated to a different value.Pillow/src/PIL/FliImagePlugin.py
Lines 76 to 81 in 31eee6e
But before it is used again, and before the end of
__init__()
, it is set back to 128.Pillow/src/PIL/FliImagePlugin.py
Line 108 in 31eee6e
Pillow/src/PIL/FliImagePlugin.py
Lines 128 to 132 in 31eee6e
Pillow/src/PIL/FliImagePlugin.py
Lines 137 to 143 in 31eee6e
So it seems simpler to just keep
self.__offset
at 128.