Add clarification for --enable-framework in macOS build instructions #1646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
hugovk
reviewed
Aug 29, 2025
Comment on lines
+714
to
+716
| Without ``--enable-framework``, you still get a working command-line | ||
| ``python3``, but certain macOS-specific integrations (GUI event loops, | ||
| app embedding, etc.) will not work. |
There was a problem hiding this comment.
Suggested change
| Without ``--enable-framework``, you still get a working command-line | |
| ``python3``, but certain macOS-specific integrations (GUI event loops, | |
| app embedding, etc.) will not work. | |
| Without ``--enable-framework``, you still get a working command-line | |
| ``python3``, but certain macOS-specific integrations (such as GUI event | |
| loops and app embedding) will not work. |
|
cc @ned-deily |
|
Thanks for the PR but the section that it adds the clarification to refers to the steps in cross-building Python targeted for iOS and iOS simulators, not for Pythons running on macOS. The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the macOS build instructions to explain what the --enable-framework option does.
The note clarifies that this flag builds Python as a macOS framework, which is required for GUI modules like tkinter to function correctly.
📚 Documentation preview 📚: https://cpython-devguide--1646.org.readthedocs.build/