Skip to content

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Sep 11, 2025

Did various edits, added a few additional sections, and reordered some sections.

@JukkaL JukkaL changed the title Updated to 1.18 changelog Updates to 1.18 changelog Sep 11, 2025
Copy link
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, some minor comments

CHANGELOG.md Outdated
### `--allow-redefinition-new`
### Mypy Performance Improvements

Mypy 1.18 includes numerous performance improvements, resulting in about 38% speedup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is unnecessarily precise, saying ~40% may be better.

Mypy 1.18 includes numerous performance improvements, resulting in about 38% speedup
compared to 1.17 when type checking mypy itself. In extreme cases, the improvement
can be 10x or higher. The list below is an overview of the various mypy optimizations.
Many mypyc improvements (discussed in a separate section below) also improve performance.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention --disable-expression-cache just in case, or only advise it when people report bugs?

CHANGELOG.md Outdated
convert fixed-format cache files to JSON, but details of the output JSON may be
different from the current JSON format. If you rely on being able to inspect
mypy cache files, we recommend creating a GitHub issue and explaining your use
case, so that we can more likely provide support for it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also mention using MypyFile.read(data) to inspect cache, which may be sufficient for some users?

CHANGELOG.md Outdated

Mypy 1.18 includes numerous performance improvements, resulting in a 38% overall speedup compared to 1.17
- Add `--strict-equality-for-none` to flag non-overlapping comparisons involving None (Christoph Tyralla, PR [19718](https://github.com/python/mypy/pull/19718))
- Don’t show import‑related errors after a module‑level `assert False` (Stanislav Terliakov, PR [19347](https://github.com/python/mypy/pull/19347))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it makes sense to clarify that this is for cases like assert sys.platform == "linux" at top of file.

CHANGELOG.md Outdated

### Experimental Free-threading Support for Mypyc

All mypyc tests now pass on free-threading 3.14 release candidate builds. The performance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
All mypyc tests now pass on free-threading 3.14 release candidate builds. The performance
All mypyc tests now pass on free-threading Python 3.14 release candidate builds. The performance

CHANGELOG.md Outdated

### Mypyc: Support `__new__`

Mypyc now has rudimentary support for `__new__` methods.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Mypyc now has rudimentary support for `__new__` methods.
Mypyc now has rudimentary support for user-defined `__new__` methods.

CHANGELOG.md Outdated
- Avoid duplicate work when checking boolean operations (Ivan Levkivskyi, PR [19515](https://github.com/python/mypy/pull/19515))
- Optimize generic inference passes (Ivan Levkivskyi, PR [19501](https://github.com/python/mypy/pull/19501))
- Speed up the default plugin (Jukka Lehtosalo, PR [19462](https://github.com/python/mypy/pull/19462))
- Speed up the default plugin (Jukka Lehtosalo, PR [19385](https://github.com/python/mypy/pull/19385))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe merge these two PR into single line, like few lines above?

@JukkaL JukkaL merged commit 73fa69e into master Sep 11, 2025
2 checks passed
@JukkaL JukkaL deleted the changelog-1.18-updates branch September 11, 2025 13:04
KevinRK29 pushed a commit that referenced this pull request Sep 11, 2025
Did various edits, added a few additional sections, and reordered some
sections.

(cherry picked from commit 73fa69e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants