fix: Remove input aliasing of builtin ops #2276

gs-olive · 2023-08-29T16:55:25Z

Description

Add replacements for inplace builtin operators with their out-of-place equivalents
Add utility to automatically perform replacement prior to AOT tracing
Add regression test cases to verify inplace operators are replaced accurately

Type of change

Please delete options that are not relevant and/or add your own.

Bug fix (non-breaking change which fixes an issue)

Checklist:

[ x ] My code follows the style guidelines of this project (You can use the linters)
[ x ] I have performed a self-review of my own code
[ x ] I have commented my code, particularly in hard-to-understand areas and hacks
[ x ] I have made corresponding changes to the documentation
[ x ] I have added tests to verify my fix or my feature
[ x ] New and existing unit tests pass locally with my changes
[ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

py/torch_tensorrt/dynamo/lowering/passes/remove_input_alias_fixing_clones.py

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

- Add replacements for inplace builtin operators with their out-of-place equivalents - Add utility to automatically perform replacement prior to AOT tracing - Add test cases to verify inplace operators are replaced accurately

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

narendasan

LGTM, passes on 2.1-rc, failures on 2.2.dev will be resolved in main

gs-olive self-assigned this Aug 29, 2023

facebook-github-bot added the cla signed label Aug 29, 2023

github-actions bot requested a review from narendasan August 29, 2023 16:55

github-actions bot approved these changes Aug 29, 2023

View reviewed changes

gs-olive force-pushed the replace_builtin_ops branch from 0fa3010 to 533d382 Compare August 29, 2023 22:42

github-actions bot approved these changes Aug 29, 2023

View reviewed changes

gs-olive force-pushed the dynamo_tensor_freeze branch 4 times, most recently from 4930dc8 to 6ff9b78 Compare August 30, 2023 22:32

gs-olive force-pushed the replace_builtin_ops branch from 533d382 to feceab1 Compare August 30, 2023 22:35

github-actions bot approved these changes Aug 30, 2023

View reviewed changes

gs-olive force-pushed the dynamo_tensor_freeze branch from 6ff9b78 to 07b492b Compare August 30, 2023 23:01

gs-olive force-pushed the replace_builtin_ops branch from feceab1 to 0fa5c13 Compare August 30, 2023 23:02

github-actions bot approved these changes Aug 30, 2023

View reviewed changes

gs-olive force-pushed the replace_builtin_ops branch from 0fa5c13 to 43d21b2 Compare August 31, 2023 01:07

gs-olive changed the base branch from dynamo_tensor_freeze to post_aten_passes August 31, 2023 01:08

github-actions bot approved these changes Aug 31, 2023

View reviewed changes

gs-olive added the WIP Work is in progress, pull request should not be merged yet label Aug 31, 2023

github-actions bot requested a review from peri044 August 31, 2023 01:13

github-actions bot approved these changes Sep 12, 2023

View reviewed changes

gs-olive force-pushed the replace_builtin_ops branch from f23cbb7 to 1d241af Compare September 12, 2023 02:26

github-actions bot approved these changes Sep 12, 2023

View reviewed changes

gs-olive force-pushed the post_aten_passes branch 4 times, most recently from fa320e2 to 6826369 Compare September 12, 2023 21:19

gs-olive commented Sep 12, 2023

View reviewed changes

py/torch_tensorrt/dynamo/lowering/passes/remove_input_alias_fixing_clones.py Show resolved Hide resolved

gs-olive force-pushed the post_aten_passes branch from 6826369 to 7ebadcd Compare September 12, 2023 23:11

gs-olive force-pushed the replace_builtin_ops branch from 1d241af to 28cf31a Compare September 13, 2023 19:24

github-actions bot approved these changes Sep 13, 2023

View reviewed changes

gs-olive force-pushed the replace_builtin_ops branch from 28cf31a to c63e411 Compare September 13, 2023 19:33

github-actions bot approved these changes Sep 13, 2023

View reviewed changes

gs-olive force-pushed the post_aten_passes branch 3 times, most recently from 8ae4510 to 7fa0a0c Compare September 21, 2023 00:43

Base automatically changed from post_aten_passes to main September 22, 2023 18:15

gs-olive added 2 commits September 25, 2023 14:52

fix: Remove input aliasing with builtin ops

ca6b235

- Add replacements for inplace builtin operators with their out-of-place equivalents - Add utility to automatically perform replacement prior to AOT tracing - Add test cases to verify inplace operators are replaced accurately

fix: Repair input aliasing with clone insertion

82b171d

gs-olive force-pushed the replace_builtin_ops branch from c63e411 to 82b171d Compare September 25, 2023 22:05

gs-olive removed the WIP Work is in progress, pull request should not be merged yet label Sep 25, 2023

github-actions bot approved these changes Sep 25, 2023

View reviewed changes

narendasan approved these changes Sep 26, 2023

View reviewed changes

gs-olive merged commit 7daa112 into main Sep 26, 2023

gs-olive deleted the replace_builtin_ops branch September 26, 2023 21:46

fix: Remove input aliasing of builtin ops #2276

fix: Remove input aliasing of builtin ops #2276

Uh oh!

Conversation

gs-olive commented Aug 29, 2023

Description

Type of change

Checklist:

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

narendasan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!