Skip to content

Make MCP work with langchain4j agents #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2025
Merged

Make MCP work with langchain4j agents #1758

merged 1 commit into from
Sep 12, 2025

Conversation

mariofusco
Copy link
Collaborator

No description provided.

@mariofusco mariofusco requested a review from geoand September 10, 2025 12:40
@mariofusco mariofusco requested a review from a team as a code owner September 10, 2025 12:40
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@geoand
Copy link
Collaborator

geoand commented Sep 10, 2025

I've fixed most of the problems. No changes are needed to upstream

@lordofthejars
Copy link
Contributor

Thanks for this Mario

@geoand
Copy link
Collaborator

geoand commented Sep 10, 2025

@mariofusco I think I have done all I can on the Quarkus LangChain4j side to make AgentMcpClientTest pass, but it still doesn't.
I believe the reason is that in LangChain4j, the ToolsProvider is never invoked.

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@mariofusco
Copy link
Collaborator Author

@mariofusco I think I have done all I can on the Quarkus LangChain4j side to make AgentMcpClientTest pass, but it still doesn't. I believe the reason is that in LangChain4j, the ToolsProvider is never invoked.

I will give a look, thanks.

@geoand
Copy link
Collaborator

geoand commented Sep 11, 2025

🙏🏽

@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@geoand geoand force-pushed the agent-with-mcp branch 2 times, most recently from 37e05f3 to e9688b1 Compare September 12, 2025 04:27
@quarkus-bot quarkus-bot

This comment has been minimized.

Sign in to view
@mariofusco @geoand
Make MCP to work with langchain4j agents
b1c680b 
Co-authored-by: Georgios Andrianakis <[email protected]>
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Sep 12, 2025

Status for workflow Build (on pull request)

This is the status report for running Build (on pull request) on commit b1c680b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit beea2d3 into quarkiverse:main Sep 12, 2025
80 checks passed
@geoand geoand changed the title Make MCP to work with langchain4j agents Make MCP work with langchain4j agents Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand Awaiting requested review from geoand

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mariofusco @geoand @lordofthejars