Support for java 17 in generated projects - Codestarts #20849

netodevel · 2021-10-18T20:07:18Z

Fixes #20752

...main/resources/codestarts/quarkus/buildtool/gradle-kotlin-dsl/base/build-layout.include.qute

...esources/codestarts/quarkus/tooling/dockerfiles/base/src/main/docker/Dockerfile.tpl.qute.jvm

ia3andy · 2021-10-19T14:40:07Z

It looks pretty good, don't forget to squash it to 1 commit

netodevel · 2021-10-19T14:44:37Z

Thanks for the quick review, but it's still on WIP. I will do some more testing as soon as i finish i notice for a second review

ia3andy · 2021-11-19T10:04:36Z

@netodevel the JDK 17 is now available. Instead of installing the package, we are going to use a different base image (as suggested by @cescoffier on zulip):

####
# This Dockerfile is used in order to build a container that runs the Quarkus application in JVM mode
#
# Before building the container image run:
#
# ./mvnw package
#
# Then, build the image with:
#
# docker build -f src/main/docker/Dockerfile.jvm -t quarkus/getting-started-jvm .
#
# Then run the container using:
#
# docker run -i --rm -p 8080:8080 quarkus/getting-started-jvm
#
# If you want to include the debug port into your docker image
# you will have to expose the debug port (default 5005) like this :  EXPOSE 8080 5050
#
# Then run the container using :
#
# docker run -i --rm -p 8080:8080 -p 5005:5005 -e JAVA_ENABLE_DEBUG="true" quarkus/getting-started-jvm
#
###
FROM registry.redhat.io/ubi8/openjdk-17-runtime:1.10-5

ARG RUN_JAVA_VERSION=1.3.8
ENV LANG='en_US.UTF-8' LANGUAGE='en_US:en'

# Configure the JAVA_OPTIONS, you can add -XshowSettings:vm to also display the heap size.
ENV JAVA_OPTIONS="-Dquarkus.http.host=0.0.0.0 -Djava.util.logging.manager=org.jboss.logmanager.LogManager"
# We make four distinct layers so if there are application changes the library layers can be re-used
COPY --chown=185 target/quarkus-app/lib/ /deployments/lib/
COPY --chown=185 target/quarkus-app/*.jar /deployments/
COPY --chown=185 target/quarkus-app/app/ /deployments/app/
COPY --chown=185 target/quarkus-app/quarkus/ /deployments/quarkus/

EXPOSE 8080
USER 185

ENTRYPOINT [ "java", "-jar", "/deployments/quarkus-run.jar" ]

We should also use a openjdk runtime base image for previous versions.

As this is a priority, if you are not available, I will continue the dev for this later today on this PR (but you'll keep the credit for your work of course), let me know..

ia3andy · 2021-11-19T17:12:23Z

I prepared a commit with the changes: ia3andy@fdf6124

But it seems that jdk 17 is on a different repository registry.redhat.io which has an extra layer of security:
https://catalog.redhat.com/software/containers/ubi8/openjdk-17-runtime/618bdc5f843af1624c4e4ba8?container-tabs=gti&gti-tabs=registry-tokens

IMO having to login or use a token to pull the image is a blocker.

cc @maxandersen @cescoffier

...rc/main/resources/codestarts/quarkus/tooling/dockerfiles/base/Dockerfile-layout.include.qute

ia3andy · 2021-11-22T14:57:33Z

I pushed my commit, this PR needs to be squashed and rebased from main.

Java 17 Runtime is in the process of being pushed to the unauthenticated repository:
https://issues.redhat.com/browse/CLOUDDST-10475

This PR will have to wait for this registry.access.redhat.com/ubi8/openjdk-17-runtime to be available.

...rc/main/resources/codestarts/quarkus/tooling/dockerfiles/base/Dockerfile-layout.include.qute

...s/devtools-common/src/main/java/io/quarkus/devtools/project/codegen/CreateProjectHelper.java

quarkus-bot · 2021-11-22T19:23:41Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `8c32b9a`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs
⌛	MicroProfile TCKs Tests	`Verify`	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: independent-projects/tools/devtools-testing 
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/gradle/gradle-model and 5 more

📦 independent-projects/tools/devtools-testing

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyJavaCustom(TestInfo) line 75 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyScalaCustom(TestInfo) line 157 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateMavenDefaultJava(TestInfo) line 185 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateMavenConfigYamlJava(TestInfo) line 223 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateMavenResteasyJava(TestInfo) line 204 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyKotlinCustom(TestInfo) line 124 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

⚙️ JVM Tests - JDK 11 Windows #

- Failing: independent-projects/tools/devtools-testing 
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/gradle/gradle-model and 5 more

📦 independent-projects/tools/devtools-testing

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyJavaCustom(TestInfo) line 75 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyScalaCustom(TestInfo) line 157 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateMavenDefaultJava(TestInfo) line 185 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateMavenConfigYamlJava(TestInfo) line 223 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateMavenResteasyJava(TestInfo) line 204 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyKotlinCustom(TestInfo) line 124 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

⚙️ JVM Tests - JDK 17 #

- Failing: independent-projects/tools/devtools-testing 
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/gradle/gradle-model and 5 more

📦 independent-projects/tools/devtools-testing

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyJavaCustom(TestInfo) line 75 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyScalaCustom(TestInfo) line 157 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateMavenDefaultJava(TestInfo) line 185 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateMavenConfigYamlJava(TestInfo) line 223 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateMavenResteasyJava(TestInfo) line 204 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyKotlinCustom(TestInfo) line 124 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

quarkus-bot · 2021-11-22T23:22:33Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `1865ac8`

Status	Name	Step	Failures	Logs	Raw logs
✖	Initial JDK 11 Build	`Build`	Failures	Logs	Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: independent-projects/tools/devtools-common 
! Skipped: core/deployment core/test-extension/deployment core/test-extension/runtime and 640 more

📦 independent-projects/tools/devtools-common

✖ Failed to execute goal net.revelc.code:impsort-maven-plugin:1.6.2:check (check-imports) on project quarkus-devtools-common: Imports are not sorted in /home/runner/work/quarkus/quarkus/independent-projects/tools/devtools-common/src/test/java/io/quarkus/devtools/project/codegen/CreateProjectHelperTest.java

ia3andy · 2021-11-23T06:25:42Z

@netodevel you need to run mvn process-sources to format the files and fix the build.

quarkus-bot · 2021-11-23T16:05:13Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `c338e50`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	⚠️ Check →	Logs	Raw logs

Full information is available in the Build summary check run.

⚠️ Errors occurred while downloading the build reports. This report is incomplete.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: independent-projects/tools/devtools-testing 
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/gradle/gradle-model and 5 more

📦 independent-projects/tools/devtools-testing

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyJavaCustom(TestInfo) line 75 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyScalaCustom(TestInfo) line 157 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateMavenDefaultJava(TestInfo) line 185 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateMavenConfigYamlJava(TestInfo) line 223 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateMavenResteasyJava(TestInfo) line 204 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyKotlinCustom(TestInfo) line 124 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

⚙️ JVM Tests - JDK 11 Windows #

- Failing: independent-projects/tools/devtools-testing 
! Skipped: devtools/cli devtools/gradle/gradle-application-plugin devtools/gradle/gradle-model and 5 more

📦 independent-projects/tools/devtools-testing

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyJavaCustom(TestInfo) line 75 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyScalaCustom(TestInfo) line 157 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateMavenDefaultJava(TestInfo) line 185 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateMavenConfigYamlJava(TestInfo) line 223 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateMavenResteasyJava(TestInfo) line 204 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

✖ io.quarkus.devtools.codestarts.quarkus.QuarkusCodestartGenerationTest.generateRESTEasyKotlinCustom(TestInfo) line 124 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

ia3andy · 2021-11-23T17:49:22Z

It seems you need to fix the tests snapshot files (by running them with -Dsnap)

...s/codestarts/quarkus/tooling/dockerfiles/base/src/main/docker/Dockerfile.tpl.qute.legacy-jar

...ing/src/test/java/io/quarkus/devtools/codestarts/quarkus/QuarkusCodestartGenerationTest.java

...s/devtools-common/src/main/java/io/quarkus/devtools/project/codegen/CreateProjectHelper.java

...main/resources/codestarts/quarkus/buildtool/gradle-kotlin-dsl/base/build-layout.include.qute

...starts/src/main/resources/codestarts/quarkus/buildtool/gradle/base/build-layout.include.qute

...s/devtools-common/src/main/java/io/quarkus/devtools/project/codegen/CreateProjectHelper.java

Adding support to java versions lts Updated template of builds for support java 17 Fixs imports Remove sysout Change codestart dockerfiles to use openjdk-xx-runtime Remove no longer needed RUN_JAVA_VERSION Fixs code formatting Fixs of code review Remove the conversion to integer from the java_version Remove java 8 and set java 11 to default Fixs tests of codestarts generation

gastaldi

Looks good to me! Great job!

...rc/main/resources/codestarts/quarkus/tooling/dockerfiles/base/Dockerfile-layout.include.qute

ia3andy

I think we are good to go.

Thanks a lot @netodevel!!! This was not an easy one to take to completion 🍾🥳

ia3andy · 2021-11-25T07:25:56Z

If we have problems we can always iterate from this..

netodevel · 2021-11-25T11:06:55Z

@ia3andy, Thanks a lot for all the help you gave me :)

geoand · 2021-12-10T08:12:47Z

IIUC, the base image has been changed, correct? If so, this is a breaking change and we should label it as such.

quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Oct 18, 2021

netodevel mentioned this pull request Oct 18, 2021

Java 17 is not reflected as source/target of generated project #20752

Closed

netodevel changed the title ~~WIP: Netodevel/fixs codestart target java~~ WIP: Fixs codestart target java Oct 18, 2021

ia3andy reviewed Oct 19, 2021

View reviewed changes

...main/resources/codestarts/quarkus/buildtool/gradle-kotlin-dsl/base/build-layout.include.qute Outdated Show resolved Hide resolved

ia3andy reviewed Oct 19, 2021

View reviewed changes

...esources/codestarts/quarkus/tooling/dockerfiles/base/src/main/docker/Dockerfile.tpl.qute.jvm Show resolved Hide resolved

ia3andy changed the title ~~WIP: Fixs codestart target java~~ Support for java 17 in generated projects - Codestarts (WIP) Oct 26, 2021

maxandersen mentioned this pull request Nov 16, 2021

Support Java 17 #21481

Closed

11 tasks

gastaldi reviewed Nov 22, 2021

View reviewed changes

...rc/main/resources/codestarts/quarkus/tooling/dockerfiles/base/Dockerfile-layout.include.qute Outdated Show resolved Hide resolved

gastaldi reviewed Nov 22, 2021

View reviewed changes

...rc/main/resources/codestarts/quarkus/tooling/dockerfiles/base/Dockerfile-layout.include.qute Show resolved Hide resolved

gastaldi reviewed Nov 22, 2021

View reviewed changes

...s/devtools-common/src/main/java/io/quarkus/devtools/project/codegen/CreateProjectHelper.java Outdated Show resolved Hide resolved

netodevel force-pushed the netodevel/fixs-codestart-target-java branch from e17db85 to 1865ac8 Compare November 22, 2021 23:11

This was referenced Nov 23, 2021

Add Java version picker quarkusio/code.quarkus.io#595

Closed

Add a parameter to select the java version for generated Quarkus projects (CLI and Maven) #21629

Closed

netodevel force-pushed the netodevel/fixs-codestart-target-java branch from f47f277 to c338e50 Compare November 23, 2021 11:48

ebullient reviewed Nov 23, 2021

View reviewed changes

...s/codestarts/quarkus/tooling/dockerfiles/base/src/main/docker/Dockerfile.tpl.qute.legacy-jar Show resolved Hide resolved

netodevel force-pushed the netodevel/fixs-codestart-target-java branch from 02ec0e9 to 86030b3 Compare November 24, 2021 00:32

netodevel commented Nov 24, 2021

View reviewed changes

...ing/src/test/java/io/quarkus/devtools/codestarts/quarkus/QuarkusCodestartGenerationTest.java Show resolved Hide resolved

gastaldi reviewed Nov 24, 2021

View reviewed changes

...s/devtools-common/src/main/java/io/quarkus/devtools/project/codegen/CreateProjectHelper.java Outdated Show resolved Hide resolved

ia3andy reviewed Nov 24, 2021

View reviewed changes

...main/resources/codestarts/quarkus/buildtool/gradle-kotlin-dsl/base/build-layout.include.qute Outdated Show resolved Hide resolved

ia3andy reviewed Nov 24, 2021

View reviewed changes

...starts/src/main/resources/codestarts/quarkus/buildtool/gradle/base/build-layout.include.qute Outdated Show resolved Hide resolved

ia3andy reviewed Nov 24, 2021

View reviewed changes

...s/devtools-common/src/main/java/io/quarkus/devtools/project/codegen/CreateProjectHelper.java Outdated Show resolved Hide resolved

ia3andy reviewed Nov 24, 2021

View reviewed changes

...s/devtools-common/src/main/java/io/quarkus/devtools/project/codegen/CreateProjectHelper.java Outdated Show resolved Hide resolved

netodevel force-pushed the netodevel/fixs-codestart-target-java branch from 345b2a5 to c24179a Compare November 24, 2021 19:38

gastaldi approved these changes Nov 24, 2021

View reviewed changes

netodevel changed the title ~~Support for java 17 in generated projects - Codestarts (WIP)~~ Support for java 17 in generated projects - Codestarts Nov 24, 2021

maxandersen reviewed Nov 24, 2021

View reviewed changes

...rc/main/resources/codestarts/quarkus/tooling/dockerfiles/base/Dockerfile-layout.include.qute Show resolved Hide resolved

...rc/main/resources/codestarts/quarkus/tooling/dockerfiles/base/Dockerfile-layout.include.qute Show resolved Hide resolved

ia3andy approved these changes Nov 25, 2021

View reviewed changes

ia3andy merged commit fbdcec8 into quarkusio:main Nov 25, 2021

quarkus-bot bot added this to the 2.6 - main milestone Nov 25, 2021

ia3andy added the release/noteworthy-feature label Nov 25, 2021

rsvoboda mentioned this pull request Jan 27, 2022

jvmTarget for kotlin-maven-plugin set to 11 even if project is generated with Java 17 #23235

Closed

Support for java 17 in generated projects - Codestarts #20849

Support for java 17 in generated projects - Codestarts #20849

Uh oh!

Conversation

netodevel commented Oct 18, 2021 • edited by gsmet Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ia3andy commented Oct 19, 2021

Uh oh!

netodevel commented Oct 19, 2021

Uh oh!

ia3andy commented Nov 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ia3andy commented Nov 19, 2021

Uh oh!

Uh oh!

ia3andy commented Nov 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

quarkus-bot bot commented Nov 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failing Jobs - Building 8c32b9a

Failures

⚙️ JVM Tests - JDK 11 #

📦 independent-projects/tools/devtools-testing

⚙️ JVM Tests - JDK 11 Windows #

📦 independent-projects/tools/devtools-testing

⚙️ JVM Tests - JDK 17 #

📦 independent-projects/tools/devtools-testing

Uh oh!

quarkus-bot bot commented Nov 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failing Jobs - Building 1865ac8

Failures

⚙️ Initial JDK 11 Build #

📦 independent-projects/tools/devtools-common

Uh oh!

ia3andy commented Nov 23, 2021

Uh oh!

quarkus-bot bot commented Nov 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Failing Jobs - Building c338e50

Failures

⚙️ JVM Tests - JDK 11 #

📦 independent-projects/tools/devtools-testing

⚙️ JVM Tests - JDK 11 Windows #

📦 independent-projects/tools/devtools-testing

Uh oh!

ia3andy commented Nov 23, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gastaldi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ia3andy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ia3andy commented Nov 25, 2021

Uh oh!

netodevel commented Nov 25, 2021

Uh oh!

geoand commented Dec 10, 2021

Uh oh!

Uh oh!

netodevel commented Oct 18, 2021 •

edited by gsmet

Loading

ia3andy commented Nov 19, 2021 •

edited

Loading

ia3andy commented Nov 22, 2021 •

edited

Loading

quarkus-bot bot commented Nov 22, 2021 •

edited

Loading

Failing Jobs - Building `8c32b9a`

quarkus-bot bot commented Nov 22, 2021 •

edited

Loading

Failing Jobs - Building `1865ac8`

quarkus-bot bot commented Nov 23, 2021 •

edited

Loading

Failing Jobs - Building `c338e50`

ia3andy left a comment •

edited

Loading