Skip to content

Take follow-redirects config into account for programmatic client created #45492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2025
Merged

Take follow-redirects config into account for programmatic client created #45492

merged 1 commit into from
Jan 12, 2025

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 10, 2025 •
edited
Loading

This property (as other config properties) is meant to apply to all clients, including ones created
programmatically.
Users can still override this by using .followRedirects() on the client builder

@geoand
Take follow-redirects config into account for programmatic client cre…
4f22bf7 
…ated

This property (as other config properties) is meant
to apply to all clients, including ones created
programmatically.
Users can still override this by using
.followRedirects() on the builder
@geoand geoand requested a review from cescoffier January 10, 2025 08:14
@geoand
Copy link
Contributor Author

geoand commented Jan 10, 2025 •
edited
Loading

cc @maxandersen who first discovered the issue

@github-actions GitHub Actions
Copy link

🎊 PR Preview 6742705 has been successfully built and deployed to https://quarkus-pr-main-45492-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 10, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 4f22bf7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jan 10, 2025 •
edited by github-actions bot
Loading

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 4f22bf7.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit ec6bf3c into quarkusio:main Jan 12, 2025
29 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.18 - main milestone Jan 12, 2025
@geoand geoand deleted the rest-client-global-redirect branch January 16, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoffier cescoffier cescoffier approved these changes

Assignees
No one assigned
Labels
area/rest area/rest-client release/breaking-change
Projects
None yet
Milestone
3.18.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@geoand @cescoffier