Skip to content

Conversation

dreab8
Copy link
Contributor

@dreab8 dreab8 commented Feb 3, 2025

Fixes #44645

@quarkus-bot quarkus-bot bot added the area/hibernate-orm Hibernate ORM label Feb 3, 2025
Copy link

quarkus-bot bot commented Feb 3, 2025

/cc @gsmet (hibernate-orm)

@dreab8 dreab8 requested a review from yrodiere February 3, 2025 11:53
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM: I don't see any other Quarkus issue fixed by this PR, and the Bytebuddy dependency didn't change.

Hey @DavideD can you confirm we don't need a Hibernate Reactive upgrade?

@DavideD
Copy link
Contributor

DavideD commented Feb 3, 2025

That should be right. But, I will run a quick test to double check

@DavideD
Copy link
Contributor

DavideD commented Feb 3, 2025

Hey @DavideD can you confirm we don't need a Hibernate Reactive upgrade?

Yep, it works without any additional change in Hibernate Reactive: hibernate/hibernate-reactive#2095

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 3, 2025
@gsmet gsmet merged commit 400daf0 into quarkusio:main Feb 3, 2025
51 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 3, 2025
@quarkus-bot quarkus-bot bot added this to the 3.19 - main milestone Feb 3, 2025
@gsmet
Copy link
Member

gsmet commented Feb 3, 2025

@DavideD thanks for checking!

Copy link

quarkus-bot bot commented Feb 3, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 42a8ef2.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@gsmet gsmet modified the milestones: 3.19 - main, 3.18.2 Feb 4, 2025
@gsmet gsmet modified the milestones: 3.18.2, 3.15.4 Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/hibernate-orm Hibernate ORM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException from Hibernate ORM when there is a problem establishing a connection
4 participants