Workaround Netty SSL Bouncycastle issue in native mode #46307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
michalvavrik
commented
Feb 17, 2025
michalvavrik
commented
- closes: Private key in PKCS#1 PEM format not working with gRPC in native image #46279
- I have opened Improve SSL context support using BouncyCastlePemReader in native images netty/netty#14826, no idea if there is a chance this will get addressed
- see Private key in PKCS#1 PEM format not working with gRPC in native image #46279 (comment) for more context
Status for workflow
|
sberyozkin
approved these changes
Feb 17, 2025
Absolutely, and thanks. |
zakkak
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Not a BC expert, but it looks good to me. Thanks @michalvavrik !
|
Note that similar code is now present in Netty Handler netty/netty#14855 so we can remove this workaround once Quarkus bumps to 4.1.119.Final. |
rsvoboda
added a commit
to rsvoboda/quarkus
that referenced
this pull request
Apr 30, 2025
This reverts code changes from quarkusio#46307, test coverage is kept
holly-cummins
pushed a commit
to holly-cummins/quarkus
that referenced
this pull request
May 6, 2025
This reverts code changes from quarkusio#46307, test coverage is kept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.