Skip to content

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Feb 26, 2025

This is a follow-up of #46464.

Given the purpose of the PR was to improve dev mode reload performance, I think it's worth avoiding the extra allocations.

This is a follow-up of quarkusio#46464.

Given the purpose of the PR was to improve dev mode reload performance,
I think it's worth avoid the extra allocations.
@gsmet gsmet requested review from Postremus and geoand February 26, 2025 14:30
Copy link
Member

@Postremus Postremus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

quarkus-bot bot commented Feb 26, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 064f4c8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 extensions/micrometer/deployment

io.quarkus.micrometer.deployment.binder.VertxConnectionMetricsTest.testConnectionMetrics - History

  • event executor terminated - java.util.concurrent.RejectedExecutionException
java.util.concurrent.RejectedExecutionException: event executor terminated
	at io.netty.util.concurrent.SingleThreadEventExecutor.reject(SingleThreadEventExecutor.java:934)
	at io.netty.util.concurrent.SingleThreadEventExecutor.offerTask(SingleThreadEventExecutor.java:353)
	at io.netty.util.concurrent.SingleThreadEventExecutor.addTask(SingleThreadEventExecutor.java:346)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:836)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute0(SingleThreadEventExecutor.java:827)
	at io.netty.util.concurrent.SingleThreadEventExecutor.execute(SingleThreadEventExecutor.java:817)
	at io.vertx.core.impl.EventLoopExecutor.execute(EventLoopExecutor.java:35)

@geoand geoand merged commit 890fe3f into quarkusio:main Feb 26, 2025
51 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.21 - main milestone Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants