Fix various issues in refreshed quarkus update

[gsmet]

I started having a look as bold and underline were leaking (it's very visible when running the tests from https://github.com/quarkusio/quarkus-updates) and things led to others.

One important thing is that the target/rewrite directory was dropped by the mvn clean process-sources so you ended up with no logs being available.

I did a lot of manual testing on my side.

This needs to go in before we push the first final 3.20.

Fixes #46639 (per Rostislav's comment below)

[ia3andy]

Didn't test it, but code looks good! Thanks!

[ia3andy]

We might need to store the logs in a buffer before writing them in the file (to avoid file locking):
#46639 (comment)

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 1887469.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[ia3andy]

@gsmet any reason to do clean process-source and not just process-source?

[ia3andy]

Ah you already removed the clean 🙏 (ignore my previous messages)

[rsvoboda]

I wanted to try this on my wife's Windows machine, but I hit #46792
I will try to install git and give it second try :/

[rsvoboda]

This fixes #46639, and the update command is now finished successfully.

After installing git and cloning I could build Quarkus, on that non-dev machine it took 33 minutes with -Dquickly -Dno-test-modules :/ And the time wasn't massively spent on downloads as I have a fibre channel connection at home :)

Just for the record, I initially built the fork on my dev machine and copied quarkus-cli-999-SNAPSHOT-runner.jar to the Windows machine, but it's not working approach as update is called through quarkus maven plugin. So that's why I needed to build and install the bits on Windows machine ...