Introduce @RegisterResourceBundle and @RegisterResources

[Eng-Fouad]

These annotations are used to register resources in native image.

• Resolves: Introduce @RegisterResourceBundle and @RegisterResources to register resources in native image #48804

[github-actions]

🙈 The PR is closed and the preview is expired.

[gsmet]

Hey @Eng-Fouad , given you contribute quite often, you should have a look at some aliases I created here:

https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#using-aliases

I usually use build-fast always to check I haven't broken anything inadvertently but format can be useful to fix the formatting quickly.

[Eng-Fouad]

@zakkak Could you please review this PR. Thanks.

[zakkak]

Hi @Eng-Fouad, thank you for your contribution.
Please see my comments.

[Eng-Fouad]

Hi @Eng-Fouad, thank you for your contribution. Please see my comments.

Updated according to your comments. Thanks.

[Eng-Fouad]

This is weird. I have a newline at the end of each file locally, but it got dropped on pushing to GitHub.

[Eng-Fouad]

This is weird. I have a newline at the end of each file locally, but it got dropped on pushing to GitHub.

Well. Github just never show the newline at end of the file on preview:

@zakkak Could you please review this PR again? Thanks :)

[geoand]

Any chance we could introduce these into one of our native tests?

[Eng-Fouad]

Any chance we could introduce these into one of our native tests?

Currently there are no tests for @RegisterForReflection/@RegisterForProxy either. Maybe tests could be added to the 4 annotations in a separate PR?

[geoand]

I would much prefer to have this PR add something in one of our integration tests - I assume it won't be too hard.

For @RegisterForProxy, I agree we can add something in a follow-up.

[Eng-Fouad]

I would much prefer to have this PR add something in one of our integration tests - I assume it won't be too hard.

For @RegisterForProxy, I agree we can add something in a follow-up.

Can you please give me an example for native tests in integration-tests that I can copy from? Thanks.

[geoand]

What I would do is look at integration-tests/main and check if any resources or bundles are being loaded there.
If they are, I would remove the custom configuration that makes them work and replace it with the new annotation.
If they aren't I would just add a new HTTP endpoint that reads some new resource and bundle.

[zakkak]

LGTM, thanks @Eng-Fouad.

Waiting for the integration tests requested by @geoand as well before merging.

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 860f3e9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[Eng-Fouad]

@geoand @zakkak Integration tests have been added.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 860f3e9.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

IT has been added per request.

[gsmet]

Approving as @zakkak was happy with it and an IT has been added.

See #48805 (review) .