Skip to content

Conversation

marko-bekhta
Copy link
Contributor

I've added the info about the non-default PUs as a note, since it comes from the Jakarta Data and is not "unique" to Quarkus. + updated the data tests to use multiple PUs.

This comment has been minimized.

This comment has been minimized.

Copy link

github-actions bot commented Jul 11, 2025

🙈 The PR is closed and the preview is expired.

@michalvavrik
Copy link
Member

Thanks @marko-bekhta , this docs will help. FYI I have additional Quarkus tests for QE including DEV mode (and the DEV mode seems to work fine) quarkus-qe/quarkus-test-suite#2512 but it's definitely better that this project has own test coverage and documentation.

}
----
1. Pass the name of the non-default persistence unit to the repository annotation (`other` in this example).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Pass the name of the non-default persistence unit to the repository annotation (`other` in this example).
<1> Pass the name of the non-default persistence unit to the repository annotation (`other` in this example).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh 🙈 I copied the format from the example just above : https://github.com/marko-bekhta/quarkus/blob/37c0436fad343653ffe59234f5038f505f98859e/docs/src/main/asciidoc/hibernate-orm.adoc?plain=1#L1799-L1803 and guess who was the author of that 🫤 let me fix that other example as well... Thanks! 🙂

@marko-bekhta marko-bekhta force-pushed the doc/data-repository-nondefault-pu branch from 37c0436 to 5e60303 Compare July 16, 2025 07:18
Copy link

quarkus-bot bot commented Jul 16, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 5e60303.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

Copy link

quarkus-bot bot commented Jul 16, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 5e60303.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 25d30a3 into quarkusio:main Jul 16, 2025
25 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.26 - main milestone Jul 16, 2025
@gsmet
Copy link
Member

gsmet commented Jul 16, 2025

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jakarta Data repositories can only be defined for default persistence unit
3 participants