Make quarkus:run a proper launch mode #48968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/amazon-lambda
area/core
area/devtools
|
/cc @loicmathieu (elasticsearch), @marko-bekhta (elasticsearch,hibernate-search) |
|
Note that we will have to communicate this change to extension owners in the Ecosystem as it would be nice if they could move to the new conditions for their Dev Services. I'll do a pass when this is in a release. |
The fact that we were hijacking the test one to trigger the Dev Services was problematic as some test build steps were executed. It is now a proper launch mode. Also we now identify more precisely if Dev Services or Live Reload are supported by a launch mode and I adjusted the build steps accordingly. Fixes quarkusio#48950 but I'm pretty sure some other weird behaviors could have popped up.
Status for workflow
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that we were hijacking the test one to trigger the Dev Services was problematic as some test build steps were executed.
It is now a proper launch mode.
Also we now identify more precisely if Dev Services or Live Reload are supported by a launch mode and I adjusted the build steps accordingly.
Fixes #48950 but I'm pretty sure some other weird behaviors could have popped up.