Split Hibernate ORM and Search dev-only modules

[mbellade]

Based on original work by @phillip-kruger and @aloubyansky (kept the commits separated for now).

Had to apply a small change to restore separation of concert between runtime and runtime-dev modules (before that the first relied on some static references in a dev class, but now we use proper runtime only objects).

[quarkus-bot]

/cc @gsmet (hibernate-orm,hibernate-search), @marko-bekhta (hibernate-search)

[github-actions]

🎊 PR Preview fd19048 has been successfully built and deployed to https://quarkus-pr-main-49399-preview.surge.sh/version/main/guides/

• Images of blog posts older than 3 months are not available.
• Newsletters older than 3 months are not available.

[aloubyansky]

Thanks a lot @mbellade!

@yrodiere you may want to review this one.

[Sanne]

Rebased to get CI confirmation, as we just merged another very significant patch to the ORM extension ( #49408 )

[quarkus-bot]

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 280a186.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 280a186.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
⌛	Native Tests - Messaging2		⚠️ Check →	Logs	Raw logs	🚧

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging/deployment

✖ io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

• Expecting actual: ["-3","-5","-6","-7","-8","-9","-10","-11"] to start with: ["-3", "-4", "-5", "-6"] - java.lang.AssertionError

java.lang.AssertionError: 

Expecting actual:
  ["-3","-5","-6","-7","-8","-9","-10","-11"]
to start with:
  ["-3", "-4", "-5", "-6"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:36)

---

⚙️ JVM Tests - JDK 21

📦 extensions/scheduler/deployment

✖ io.quarkus.scheduler.test.PausedSchedulerTest.testSchedulerPauseResume - History

• expected: <false> but was: <true> - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: expected: <false> but was: <true>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertFalse.failNotFalse(AssertFalse.java:63)
	at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:36)
	at org.junit.jupiter.api.AssertFalse.assertFalse(AssertFalse.java:31)
	at org.junit.jupiter.api.Assertions.assertFalse(Assertions.java:231)
	at io.quarkus.scheduler.test.PausedSchedulerTest.testSchedulerPauseResume(PausedSchedulerTest.java:47)

[gsmet]

Thanks!

[yrodiere]

Thanks!

By the way, I just noticed the JS/UI files for the dev UI are still in the deployment module, at least in the case of Hibernate ORM. Do you know if that's really necessary, or if we can/should move them to runtime-dev? Maybe @phillip-kruger would know?

[phillip-kruger]

No they should stay in deployment. (Deployment never ends up in runtime anyway)

[yrodiere]

No they should stay in deployment. (Deployment never ends up in runtime anyway)

I was more thinking of app devs who use re-augmentation and may not like security scanners flagging dependencies in JS files... Which I thought was the point of runtime-dev. But it seems I was wrong. Thanks for confirming!

[aloubyansky]

IMO, it's a good point and ideally -dev dependencies should be pulled in only in dev mode. It will probably require further refactoring to implement this split cleaner and it will be specific to each extension, of course.

[aloubyansky]

I'd be happy to help with that, in case extension authors are interested. Essentially, it would be making sure the code from different modules complies and classloading doesn't break.

[aloubyansky]

@phillip-kruger or are those resources must always be in deployment-only classpath?

[phillip-kruger]

I think so yes. They are loaded, when in dev mode, by the build time process

[aloubyansky]

Sure, the question is whether only the deployment-only classpath elements are searched. If not, then they could easily be moved to runtime-dev dependencies.