Skip to content

Conversation

Karm
Copy link
Member

@Karm Karm commented Aug 15, 2025

related to #49226

Copy-pasted Dockerfiles that work in quarkusio/quarkus-quickstarts#1560

Fonts

I took the liberty of deleting an example that just added libfreetype without pulling fontconfig and fontconfig's dependencies as I couldn't imagine an app that would initialize freetype without going down the AWT rabbit hole of looking up and initializing fontconfig too. PDFBox, POI etc., invoice documents generating apps and such use cases definitely need fontconfig too and that pulls additional dependencies. If you feel differently and have an example of a Quarkus native app that just needs libfreetype, share it here, please.

@Karm Karm requested review from galderz and cescoffier August 15, 2025 14:04
@Karm Karm self-assigned this Aug 15, 2025

This comment has been minimized.

Copy link

github-actions bot commented Aug 15, 2025

🙈 The PR is closed and the preview is expired.

@Karm
Copy link
Member Author

Karm commented Aug 15, 2025

  SUCCESS  Synced 0 package(s) to 'docs/.vale/styles'.
Running vale...
  /home/runner/vale --output=/home/runner/work/_actions/errata-ai/vale-action/reviewdog/lib/rdjsonl.tmpl --no-exit --config=docs/.vale.ini docs/src/main/asciidoc/
  E100 [lintAdoc] Runtime error
  
  asciidoctor not found
  
  Execution stopped with code 1.
Error: Vale and reviewdog exited with status code: 2

So, is this the reason why there is no preview? " asciidoctor not found " ?

This comment has been minimized.

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is about adding a note for Mac.

@gsmet
Copy link
Member

gsmet commented Aug 19, 2025

@Karm could you adjust and then we can merge.

@Karm
Copy link
Member Author

Karm commented Sep 4, 2025

Sry for the delay, circled back to this, adjusting...

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 4, 2025
Copy link

quarkus-bot bot commented Sep 4, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit 062d54b.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gastaldi gastaldi merged commit 1dc21e4 into quarkusio:main Sep 4, 2025
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.28 - main milestone Sep 4, 2025
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 4, 2025
@gsmet gsmet modified the milestones: 3.28 - main, 3.26.3 Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants