Skip to content

Conversation

MikeEdgar
Copy link
Contributor

Disable HTTP/2 clear text when quarkus.http.http2 is false. Currently, H2C remains enabled even when HTTP/2 with TLS is disabled using this property.

Fixes #49592

@MikeEdgar MikeEdgar changed the title fix: disable HTTP/2 clear text when quarkus.http.http2 is false Disable HTTP/2 clear text when quarkus.http.http2 is false Aug 20, 2025
@gastaldi gastaldi requested a review from cescoffier August 20, 2025 15:08
Copy link

quarkus-bot bot commented Aug 20, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit f66af2e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/smallrye-reactive-messaging/deployment

io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector - History

  • Expecting actual: ["-6","-7","-8","-10","-11","-12","-13","-14"] to start with: ["-6", "-7", "-8", "-9"] - java.lang.AssertionError
java.lang.AssertionError: 

Expecting actual:
  ["-6","-7","-8","-10","-11","-12","-13","-14"]
to start with:
  ["-6", "-7", "-8", "-9"]

	at io.quarkus.smallrye.reactivemessaging.hotreload.ConnectorChangeTest.testUpdatingConnector(ConnectorChangeTest.java:41)

⚙️ Gradle Tests - JDK 17 Windows

📦 integration-tests/gradle

io.quarkus.gradle.BuildConfigurationTest.buildNoOverride - History

  • Multiple Failures (1 failure) -- failure 1 -- [sub project 'without-configuration', package type 'fast-jar'] Expecting path: - org.assertj.core.error.AssertJMultipleFailuresError
org.assertj.core.error.AssertJMultipleFailuresError: 

Multiple Failures (1 failure)
-- failure 1 --
[sub project 'without-configuration', package type 'fast-jar'] 
Expecting path:
  D:\a\quarkus\quarkus\integration-tests\gradle\target\classes\build-configuration\without-configuration\build\quarkus-app\quarkus-run.jar
to exist (symbolic links were followed).

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cescoffier
Copy link
Member

For H2C we may need to intercept the request and reject the HTTP/2 ones altogether.

@cescoffier cescoffier merged commit 7bc9837 into quarkusio:main Aug 21, 2025
57 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.28 - main milestone Aug 21, 2025
@gsmet gsmet modified the milestones: 3.28 - main, 3.26.1 Aug 27, 2025
@jmartisk jmartisk modified the milestones: 3.26.1, 3.20.3 Sep 3, 2025
@MikeEdgar MikeEdgar deleted the issue-49592 branch September 4, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

H2C remains enabled with quarkus.http.http2=false
4 participants