Skip to content

Conversation

janscheidegger
Copy link
Contributor

@janscheidegger janscheidegger force-pushed the do-not-decode-query-params branch from 2c0ee45 to 7c50419 Compare August 27, 2025 11:16
@janscheidegger janscheidegger changed the title do not decode query params in request filter Do not decode query params in request filter Aug 27, 2025
@geoand
Copy link
Contributor

geoand commented Aug 28, 2025

Thanks a lot for the contribution!

It would be great if there were a test included

@aureamunoz
Copy link
Member

Thank you very much.
Yes! We would need a test for reproducing the bug before the fix and see the test green :-)

@janscheidegger janscheidegger force-pushed the do-not-decode-query-params branch from 7c50419 to 37492b5 Compare August 28, 2025 09:16
@geoand
Copy link
Contributor

geoand commented Aug 28, 2025

This comment has been minimized.

Copy link

github-actions bot commented Aug 28, 2025

😭 Deploy PR Preview failed.

@janscheidegger janscheidegger force-pushed the do-not-decode-query-params branch from c523c49 to f129fad Compare August 28, 2025 13:06
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/core area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/hibernate-orm Hibernate ORM area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/logging area/maven area/oidc area/platform Issues related to definition and interaction with Quarkus Platform area/qute The template engine labels Aug 28, 2025
@janscheidegger janscheidegger force-pushed the do-not-decode-query-params branch 2 times, most recently from f3a4700 to 6f12558 Compare August 28, 2025 13:14
@aureamunoz
Copy link
Member

cc @geoand @cescoffier

Copy link

quarkus-bot bot commented Aug 28, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit f129fad.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@janscheidegger janscheidegger force-pushed the do-not-decode-query-params branch from 6f12558 to 90c18c4 Compare August 28, 2025 14:09
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@geoand geoand removed area/documentation area/core area/arc Issue related to ARC (dependency injection) area/maven area/logging area/hibernate-orm Hibernate ORM area/oidc area/platform Issues related to definition and interaction with Quarkus Platform area/dependencies Pull requests that update a dependency file area/qute The template engine area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/rest labels Aug 28, 2025
Copy link

quarkus-bot bot commented Aug 28, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 90c18c4.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.


Flaky tests - Develocity

⚙️ JVM Tests - JDK 17 Windows

📦 independent-projects/resteasy-reactive/server/vertx

org.jboss.resteasy.reactive.server.vertx.test.sse.SseServerTestCase.shouldNotTryToSendToClosedSink - History

  • 1 expectation failed. Response body doesn't match expectation. Expected: "true" Actual: false - java.lang.AssertionError
java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.
Expected: "true"
  Actual: false

	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
	at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)

⚙️ Gradle Tests - JDK 17

📦 integration-tests/gradle

io.quarkus.gradle.BuildConfigurationTest.buildNoOverride - History

  • Multiple Failures (1 failure) -- failure 1 -- [sub project 'without-configuration', package type 'fast-jar'] Expecting path: - org.assertj.core.error.AssertJMultipleFailuresError
org.assertj.core.error.AssertJMultipleFailuresError: 

Multiple Failures (1 failure)
-- failure 1 --
[sub project 'without-configuration', package type 'fast-jar'] 
Expecting path:
  /home/runner/_work/quarkus/quarkus/integration-tests/gradle/target/classes/build-configuration/without-configuration/build/quarkus-app/quarkus-run.jar
to exist (symbolic links were followed).

@geoand geoand merged commit bcf7e56 into quarkusio:main Aug 28, 2025
39 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.28 - main milestone Aug 28, 2025
@gsmet gsmet modified the milestones: 3.28 - main, 3.26.2 Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants