Skip to content

Conversation

RoMiRoSSaN
Copy link
Contributor

Fix for a minor bug that only exists in development or testing mode.
In some cases that are extremely difficult to reproduce, a situation occurs where channels are not formed correctly. For example, channel-in, channel-out are recognized as belonging to 1 specific input channel.
The problem is that 1 common list of Incoming, Outgoing and Channel annotations was formed, and the graceful-shutdown setting was set for them as for incoming channels.
According to the documentation only incoming channels have such a setting, but not for outgoing ones.
Therefore, you can remove the setting of the property for outgoing channels.

ozangunalp
ozangunalp previously approved these changes Sep 5, 2025
Copy link
Contributor

@ozangunalp ozangunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ozangunalp ozangunalp dismissed their stale review September 5, 2025 14:35

Actually I need to check this, Channel annotations can be injected incoming channels too.

Copy link

quarkus-bot bot commented Sep 5, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit e4002a8.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messaging kafka: incorrect setting of the graceful shutdown property for dev/test modes
2 participants