Skip to content

Conversation

Eng-Fouad
Copy link
Contributor

@quarkus-bot quarkus-bot bot added the area/gradle Gradle label Sep 8, 2025
Copy link

quarkus-bot bot commented Sep 8, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b4149e0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@Eng-Fouad
Copy link
Contributor Author

cc @aloubyansky @snazy

@aloubyansky
Copy link
Member

Would this be necessary in Gradle 9.1 w/o the Quarkus plugin?

@Eng-Fouad
Copy link
Contributor Author

Would this be necessary in Gradle 9.1 w/o the Quarkus plugin?

Yes. Tested that without Quarkus plugin.

@aloubyansky
Copy link
Member

@snazy does this make sense to you?

@snazy
Copy link
Contributor

snazy commented Sep 9, 2025

Hm, not sure why the test coverage needs to be reduced. It's a valid scenario (we use it ;) ).

@Eng-Fouad
Copy link
Contributor Author

Hm, not sure why the test coverage needs to be reduced. It's a valid scenario (we use it ;) ).

The included-quarkus project is already included by nested:

@aloubyansky
Copy link
Member

AFAIU, this test project configuration issue is not specific Quarkus. Please, correct me if I'm wrong.

@Eng-Fouad
Copy link
Contributor Author

AFAIU, this test project configuration issue is not specific Quarkus. Please, correct me if I'm wrong.

That's correct.

@snazy
Copy link
Contributor

snazy commented Sep 9, 2025

The included-quarkus project is already included by nested:

Oh, are you saying that's included twice?

@Eng-Fouad
Copy link
Contributor Author

The included-quarkus project is already included by nested:

Oh, are you saying that's included twice?

Yes :)

@snazy
Copy link
Contributor

snazy commented Sep 9, 2025

Ah, okay, then everything's good.

Copy link
Member

@aloubyansky aloubyansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone!

@aloubyansky aloubyansky merged commit 749fdd7 into quarkusio:main Sep 9, 2025
21 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.28 - main milestone Sep 9, 2025
@Eng-Fouad Eng-Fouad deleted the patch-2 branch September 9, 2025 15:03
@gsmet gsmet modified the milestones: 3.28.0.CR1, 3.26.4 Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants