adding delivery status on publishing #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/getting_started/main.py
Outdated
| print("message accepted") | ||
| if status.RELEASED: | ||
| print("message not routed") | ||
| if status.REJECTED: |
There was a problem hiding this comment.
Status REJECTED should contain an optional error or description.
|
In Publish there was a bug as when publishing messages we need to setup link.snd_settle_mode to be unsettled, I also added that fix |
|
I'll merge this one for the moment as I may need to test the connection close scenario, I'm not able to find the optional field for the moment but we can have a look later on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #22
Adding this info on publishing in order to know the outcome of the Delivery