Skip to content

SSL/TLS implementation #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 28, 2025
Merged

SSL/TLS implementation #24

merged 4 commits into from
Jan 28, 2025

Conversation

DanielePalaia
Copy link
Contributor

@DanielePalaia DanielePalaia commented Jan 22, 2025 •
edited
Loading

This closes #16

This PR add support for TLS/SSL

  • When opening a new Connection we can add a new Optional parameter of type SSLConfigurationContext which specify the ca_cert and a ClientCert (a pair cert/key) to support the SSL connection.
  • The github action has been updated to support SSL testing
  • Also a Dockerfile and Makefile has been added in order to make easier to setup and run the broker

@DanielePalaia DanielePalaia force-pushed the ssl_implementation branch 3 times, most recently from 027afac to ea2837b Compare January 22, 2025 10:05
@DanielePalaia DanielePalaia force-pushed the ssl_implementation branch 4 times, most recently from 4164811 to 686fa39 Compare January 22, 2025 12:37
@DanielePalaia DanielePalaia changed the title Draft: Ssl implementation SSL/TLS implementation Jan 22, 2025
@DanielePalaia DanielePalaia marked this pull request as draft January 22, 2025 12:54
@DanielePalaia DanielePalaia added this to the 0.1.0-alpha.2 milestone Jan 22, 2025
@lukebakken lukebakken self-assigned this Jan 22, 2025
@lukebakken lukebakken self-requested a review January 22, 2025 23:20
@DanielePalaia DanielePalaia marked this pull request as ready for review January 23, 2025 08:49
lukebakken
lukebakken approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DanielePalaia DanielePalaia merged commit 1068c05 into main Jan 28, 2025
1 check passed
@DanielePalaia DanielePalaia deleted the ssl_implementation branch January 28, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@lukebakken lukebakken lukebakken approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@lukebakken lukebakken

Labels
None yet
Projects
None yet
Milestone
0.1.0-alpha.2
Development

Successfully merging this pull request may close these issues.

Implement and test tls functionality
2 participants
@DanielePalaia @lukebakken