Environment and improvements for doc compatibility #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielePalaia
force-pushed
the
environment
branch
from
b88894a to
42e7dbd
Compare
DanielePalaia
force-pushed
the
environment
branch
from
e9ba7d2 to
8553249
Compare
DanielePalaia
force-pushed
the
environment
branch
from
4f3482f to
5e62151
Compare
DanielePalaia
force-pushed
the
environment
branch
from
5e62151 to
d734ab3
Compare
DanielePalaia
changed the title
There was a problem hiding this comment.
LGTM.
I would rename the example files to a more uniform:
like:
- /examples/getting_started/getting_started.py
- /examples/streams/streams.py
- /examples/reconnection.py
etc...
and put a REAMDE.md to explain the examples details, something like:
https://github.com/rabbitmq/rabbitmq-stream-go-client/tree/main/examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #34
Introducing the Environment struct mainly to make the client api more compatible with the others.
Also contains some general improvements to adapt to other clients conventions