Return stream frame header binary in dispatch chunk callback #14189
+65
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acogoluegnes
force-pushed
the
stream-dispatching-improvements
branch
2 times, most recently
from
2ed6136 to
0b9973f
Compare
acogoluegnes
force-pushed
the
stream-dispatching-improvements
branch
3 times, most recently
from
a4b08fd to
c0aef41
Compare
acogoluegnes
force-pushed
the
stream-dispatching-improvements
branch
3 times, most recently
from
4a95db8 to
e3d6c66
Compare
kjnilsson
force-pushed
the
stream-dispatching-improvements
branch
from
e3d6c66 to
34b8900
Compare
acogoluegnes
force-pushed
the
stream-dispatching-improvements
branch
2 times, most recently
from
6f7dcc5 to
1cdc9b9
Compare
acogoluegnes
force-pushed
the
stream-dispatching-improvements
branch
4 times, most recently
from
bbfdcb0 to
fa82be8
Compare
This saves a system call by sending the frame header and the chunk header at the same time. References rabbitmq/osiris#192
This allows better use of read ahead data.
This is a switch for the read ahead optimization in Osiris.
acogoluegnes
force-pushed
the
stream-dispatching-improvements
branch
from
4a96010 to
71c4773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This saves a system call by sending the frame header and the chunk header at the same time.
References rabbitmq/osiris#192