Add config to disable sessid column fallback #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm working on removing queries in my application that should be going through the SchemaCache in production but currently are not. I found that the `sessions` table is being queried during runtime due to the `reset_column_information` when the class is loaded (which clears the SchemaCache for the `sessions` table). This commit introduces a new configuration to disable the `sessid` column fallback (which is the source of the `reset_column_information`). Since the `session_id` -> `sessid` fallback has been in place for [twenty years][1], there may be an argument to just remove it, but this gem is very very stable so breaking changes should probably be held to an even higher threshold. [1]: rails/rails@452442d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on removing queries in my application that should be going through the SchemaCache in production but currently are not. I found that the
sessionstable is being queried during runtime due to thereset_column_informationwhen the class is loaded (which clears the SchemaCache for thesessionstable).This commit introduces a new configuration to disable the
sessidcolumn fallback (which is the source of thereset_column_information).Since the
session_id->sessidfallback has been in place for twenty years, there may be an argument to just remove it, but this gem is very very stable so breaking changes should probably be held to an even higher threshold.