Turn Propshaft::Server into a proper middleware #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodorton
force-pushed
the
rack-server
branch
from
9ecdd84 to
baba517
Compare
skipkayhil
reviewed
Aug 21, 2025
| path = env["PATH_INFO"] | ||
| method = env["REQUEST_METHOD"] | ||
|
|
||
| if (method == "GET" || method == "HEAD") && path.start_with?(@assembly.prefix) |
There was a problem hiding this comment.
HEAD requests should return an empty body
https://github.com/rack/rack/blob/ee7ac5a1db5bc5c65e4b83342b8f4df88ef3c075/lib/rack/lint.rb#L819
There was a problem hiding this comment.
Rack::Head would take care of that, but yes, good point.
Fix: rails/rails#55508 Mounting Propshaft::Server in the Rails router isn't suitable because it end up executed after a long list of middlewares that may set cookies or do other transformation we don't want. In production, propshaft assets are served by `ActionDispatch::Static` (or a reverse proxy), so we should try to be as close to that as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: rails/rails#55508
Mounting Propshaft::Server in the Rails router isn't suitable because it end up executed after a long list of middlewares that may set cookies or do other transformation we don't want.
In production, propshaft assets are served by
ActionDispatch::Static(or a reverse proxy), so we should try to be as close to that as possible.